Factor out branch metadata fields in BNInstructionInfo#6923
Closed
mkrasnitski wants to merge 1 commit intoVector35:devfrom
Closed
Factor out branch metadata fields in BNInstructionInfo#6923mkrasnitski wants to merge 1 commit intoVector35:devfrom
mkrasnitski wants to merge 1 commit intoVector35:devfrom
Conversation
mkrasnitski
force-pushed
the
branch-info
branch
from
c29729b to
03496fc
Compare
Contributor
Author
|
Rebased this, should be fine for review now @emesare |
Member
|
The reason (i believe) the core def is defined like that is to shrink the size of the structure, factoring out the branch info like that will increase the size of the structure from 72 to 96 bytes, because an API wraps this and its not exposed to the end user I am going to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new
BNBranchInfotype that contains relevant info pertaining to a given instruction branch. This keeps related data together and simplifies handling instruction branches in other languages.